Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.w3c.dom.CDATASection extends org.w3c.dom.Text, so remove instance… #171

Merged

Conversation

PascalSchumacher
Copy link
Contributor

…of checks for CDATASection after instanceof checks for Text.

…of checks for CDATASection after instanceof checks for Text.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 91.919% when pulling 838efd9 on PascalSchumacher:remove_redundant_instanceOf_checks into 525f7f9 on xmlunit:master.

@coveralls
Copy link

coveralls commented Jan 1, 2020

Coverage Status

Coverage increased (+0.0005%) to 91.864% when pulling 838efd9 on PascalSchumacher:remove_redundant_instanceOf_checks into 525f7f9 on xmlunit:master.

@bodewig bodewig merged commit 06dd7b6 into xmlunit:master Jan 1, 2020
@bodewig
Copy link
Member

bodewig commented Jan 1, 2020

Strange that this never occurred to me - and thank you for the patch @PascalSchumacher .

Happy new year!

@PascalSchumacher
Copy link
Contributor Author

You are welcome.

Happy new year!

@bodewig bodewig added this to the 2.6.4 milestone Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants