Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing runtime dependencies in Java 9+ #162

Closed
swismer opened this issue Jul 25, 2019 · 2 comments
Closed

Missing runtime dependencies in Java 9+ #162

swismer opened this issue Jul 25, 2019 · 2 comments

Comments

@swismer
Copy link

swismer commented Jul 25, 2019

The following additional JAXB dependencies are required to run e.g. Input.fromJaxb(...) in Java 9+:

  • jaxb-core
  • jaxb-impl
  • activation

In xmlunit-core/pom.xml, these are already listed, but are only available for the xmlunit internal tests.
External Maven projects adding a dependency on xmlunit therefore miss these libraries, because test scoped dependencies are not transitive. I would appreciate, if

  • they could be either declared as runtime scoped dependencies (for Java 9+)
  • or marked as optional, including some documentation that the JAXB features require adding these additional dependencies manually
@bodewig bodewig added the core label Jul 27, 2019
@bodewig
Copy link
Member

bodewig commented Jul 27, 2019

You are certainly right in that JAXB becomes an optional dependency of core in Java9+. So far I assumed that anybody who wants to test the XML serialization of an object - this is what fromJaxb does would be testing code that already depended on JAXB anyway - so didn't really think about making the dependency explicit.

@bodewig bodewig added this to the 2.6.4 milestone Jul 27, 2019
@bodewig
Copy link
Member

bodewig commented Jul 27, 2019

fixed in master, will be fixed for the next release.

Thank you for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants