Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert all line separators to LF #66

Merged
merged 1 commit into from Jun 28, 2020

Conversation

karfau
Copy link
Member

@karfau karfau commented Jun 28, 2020

This just converts the files, no enforcement yet

fixes #56

This just converts the files, no enforcement yet

fixes xmldom#56
@karfau
Copy link
Member Author

karfau commented Jun 28, 2020

@brodybits Do you think it should be part of this PR to enforce LF using one of the methods described in the ticket?
And if so, which one would you prefer?

PS: I just scanned the changes and I didn't find any multiline XML snippets in those files.

Copy link
Member

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git show -b 8a31e shows no extra changes
npm test on 8a31e is OK

@brodybits brodybits merged commit 0ade062 into xmldom:master Jun 28, 2020
@karfau karfau deleted the 56/consistent-line-separators branch June 28, 2020 19:59
This was referenced Mar 9, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed line endings in the repo
2 participants