fix: Avoid iterating over prototype properties #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by adding `hasOwnProperty` checks. #436
chrisvariety
added a commit
to thoughtindustries/saml2
that referenced
this pull request
Oct 13, 2022
bbyars
added a commit
to bbyars/mountebank
that referenced
this pull request
Oct 16, 2022
mfulton26
added a commit
to mfulton26/expo-cli
that referenced
this pull request
Oct 19, 2022
[Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution') in @xmldom/xmldom and xmldom · CVE-2022-37616 · GitHub Advisory Database](GHSA-9pgh-qqpf-7wqj)
`@xmldom/xmldom` has already been patched:
[fix: Avoid iterating over prototype properties by karfau · Pull Request expo#437 · xmldom/xmldom](xmldom/xmldom#437)
newer versions exist but this is the latest patch version and there shoudln't be any breaking changes
`yarn build` and `yarn test`
EvanBacon
pushed a commit
to expo/expo-cli
that referenced
this pull request
Oct 28, 2022
[Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution') in @xmldom/xmldom and xmldom · CVE-2022-37616 · GitHub Advisory Database](GHSA-9pgh-qqpf-7wqj)
`@xmldom/xmldom` has already been patched:
[fix: Avoid iterating over prototype properties by karfau · Pull Request #437 · xmldom/xmldom](xmldom/xmldom#437)
newer versions exist but this is the latest patch version and there shoudln't be any breaking changes
`yarn build` and `yarn test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by adding
hasOwnPropertychecks.#436