New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typecheck source param before parsing #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, go for it!
FYI: 0.9.0 will change this: |
Updates
DOMParser.parseFromString
to also check that thesource
provided is a string. To prevent sax from throwing undefined errors when callingindexOf
on the source.Adds unit tests to
test/parse/simple.vows.js
to cover this edge case.Resolves #98