Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: fix main package entry #53

Closed
brodybits opened this issue Jun 21, 2020 · 1 comment · Fixed by #309
Closed

breaking: fix main package entry #53

brodybits opened this issue Jun 21, 2020 · 1 comment · Fixed by #309
Labels
needs investigation Information is missing and needs to be researched
Milestone

Comments

@brodybits
Copy link
Member

The following main entry in package.json only exports lib/dom-parser.js:

  "main": "lib/dom-parser.js",

I think the main package object should provide access to functionality of all modules in lib.

May be related to: #40, #48

@brodybits brodybits added bug Something isn't working needs investigation Information is missing and needs to be researched labels Jun 21, 2020
@brodybits brodybits added this to the 0.4.0 milestone Jun 21, 2020
@brodybits brodybits modified the milestones: 0.4.0, 0.5.0 Oct 27, 2020
@karfau karfau modified the milestones: 0.5.0, 0.7.0 Mar 10, 2021
@karfau karfau modified the milestones: 0.7.0, next release Jul 27, 2021
@karfau karfau modified the milestones: 0.7.1, next next release Aug 19, 2021
@karfau karfau linked a pull request Aug 21, 2021 that will close this issue
@karfau karfau removed the bug Something isn't working label Aug 21, 2021
@karfau karfau linked a pull request Aug 21, 2021 that will close this issue
@karfau
Copy link
Member

karfau commented Aug 24, 2021

To clarify the status: #233 deprecated the redundant exports in lib/dom-parser.js, they will be dropped from the module in the next breaking release, which will resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation Information is missing and needs to be researched
Projects
None yet
2 participants