Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM: Verify Node.lookupPrefix works according to the spec #322

Open
karfau opened this issue Sep 10, 2021 · 0 comments
Open

DOM: Verify Node.lookupPrefix works according to the spec #322

karfau opened this issue Sep 10, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation help-wanted External contributions welcome needs investigation Information is missing and needs to be researched spec:DOM Level 3 https://www.w3.org/TR/DOM-Level-3-Core/ spec:DOM Living Standard https://dom.spec.whatwg.org/
Milestone

Comments

@karfau
Copy link
Member

karfau commented Sep 10, 2021

As part of #321 a docstring was added to the implementation of Node.lookupPrefix including links to the expected implementation.

  • There seems to be some missing cases for some node types when comparing it to the specs
  • We need to test that it also works as expected when the is DOM is created using the DOMImplementaiton methods or manipulated after parsing.
  • We should understand if there is a difference in the specification between DOM Level 3 and the living standard
  • We need to either document the differences or implement it according to the spec
    • living standard should win over DOM Level 3 in case of conflicts
    • this might be a breaking change
    • Maybe it's possible to get rid of the internal _nsMap (we should compare performance though, since this method is used as part of serialization)
@karfau karfau added documentation Improvements or additions to documentation help-wanted External contributions welcome needs investigation Information is missing and needs to be researched spec:DOM Living Standard https://dom.spec.whatwg.org/ spec:DOM Level 3 https://www.w3.org/TR/DOM-Level-3-Core/ labels Sep 10, 2021
@karfau karfau added this to the before 1.0.0 milestone Sep 10, 2021
@karfau karfau modified the milestone: before 1.0.0 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help-wanted External contributions welcome needs investigation Information is missing and needs to be researched spec:DOM Level 3 https://www.w3.org/TR/DOM-Level-3-Core/ spec:DOM Living Standard https://dom.spec.whatwg.org/
Projects
Status: Has Priority
Development

No branches or pull requests

1 participant