New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standard(ize) source code formatting #29
Comments
I personally use |
I'd like to submit a PR for an Since there doesn't really seem to be a standard, it might be a good idea to not convert everything all at once... I'm playing around with a PR for a bare-minimum For indents, my vote would be to keep tabs. Not to rehash the tabs v. spaces holy war or anything, but I like customizing my indent size, and I like it when you can't accidentally highlight half an indent (as an example: lib/entities.js is indented 7 spaces). Thoughts? |
from review of pr #28 I discovered that code is sometimes indented with only tabs and sometimes with a combination of tabs and spaces. Also at least one occasion of code with no semicolon.
Most drastic would be to use
standard
,semistandard
, orprettier-standard
to reformat the code in what I think is a nicer style. (prettier-standard
actually uses theprettierx
fork of Prettier that is maintained by myself, which could be seen as an advantage or perhaps even a disadvantage)Less drastic would be to apply some simplistic rules such as only indent with tabs and always use semicolons to achieve better consistency with minimal code churn. I think it should be possible to do this with custom eslint rule configuration.
The text was updated successfully, but these errors were encountered: