Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Changelog #197

Merged
merged 1 commit into from Mar 23, 2021
Merged

docs: Update Changelog #197

merged 1 commit into from Mar 23, 2021

Conversation

karfau
Copy link
Member

@karfau karfau commented Mar 10, 2021

to keep in sync with release notes

https://github.com/xmldom/xmldom/releases/tag/0.5.0

@karfau karfau added this to the 0.6.0 milestone Mar 10, 2021
@karfau karfau requested a review from brodybits March 10, 2021 08:07
@karfau karfau mentioned this pull request Mar 10, 2021
Closed
@karfau karfau linked an issue Mar 10, 2021 that may be closed by this pull request
Changelog for 0.5.0 not mentioning BREAKING #196
Closed
@karfau
Copy link
Member Author

karfau commented Mar 10, 2021

Please just land it when you think it's good, no need to wait for me to land it.

brodybits
brodybits approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sorry I missed it before

@karfau karfau merged commit af4642e into master Mar 23, 2021
@karfau karfau deleted the 0.5.0/changelog branch March 23, 2021 06:23
@brodybits
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brodybits brodybits brodybits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Changelog for 0.5.0 not mentioning BREAKING
2 participants
@karfau @brodybits