Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint rules to avoid usage of unsupported node features? #190

Closed
karfau opened this issue Feb 26, 2021 · 0 comments · Fixed by #448
Closed

Add eslint rules to avoid usage of unsupported node features? #190

karfau opened this issue Feb 26, 2021 · 0 comments · Fixed by #448

Comments

@karfau
Copy link
Member

karfau commented Feb 26, 2021

@XhmikosR suggested to make use of some of these eslint rules: https://github.com/mysticatea/eslint-plugin-node
Which work based on the engines field in package.json.

We are already using the eslint-plugin-es5, we should check if there is an overlap and if it makes sense, since node is not our only supported environment.

@karfau karfau added enhancement needs investigation Information is missing and needs to be researched code style labels Feb 26, 2021
karfau added a commit that referenced this issue Oct 19, 2022
@karfau karfau added this to the 0.9.0 milestone Oct 19, 2022
@karfau karfau added testing and removed needs investigation Information is missing and needs to be researched labels Oct 19, 2022
karfau added a commit that referenced this issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant