Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dom): Escape ]]> when serializing CharData #181

Merged
merged 3 commits into from Jan 21, 2021

Conversation

karfau
Copy link
Member

@karfau karfau commented Jan 19, 2021

to adhere to the XML specification

https://www.w3.org/TR/xml/#NT-CharData
#58 (comment)

@karfau karfau requested a review from brodybits January 19, 2021 04:56
lib/dom.js Show resolved Hide resolved
@brodybits
Copy link
Member

LGTM in general. Unfortunately some of this is very new for me and I am relying on the comments and my understanding of the referenced specs. Thanks for working on this.

@karfau
Copy link
Member Author

karfau commented Jan 21, 2021

I needed to revert the usage of const since we decided to stick to ES5 syntax in lib. Thx eslint for reminding me. (And assigning those values to vars just to access them in a single place doesn't seem to make sense to me.)

@karfau karfau merged commit 64c7388 into xmldom:master Jan 21, 2021
@karfau karfau deleted the escape-cdata-end branch January 21, 2021 02:34
@brodybits brodybits mentioned this pull request Jan 21, 2021
@karfau karfau added this to the 0.5.0 milestone Jan 23, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants