Remove webpa common and replace go-kit/log with zap & replace go-kit/kit/metrics with prometheus/client_golang/prometheus
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulnerable Libraries (2)
More info on how to fix Vulnerable Libraries in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
denopink
added
the
webpa-common archival/deprecation
This was referenced Nov 17, 2022
renaz6
approved these changes
Nov 28, 2022
johnabass
approved these changes
Jan 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 82.50% 84.49% +1.99%
==========================================
Files 13 13
Lines 663 645 -18
==========================================
- Hits 547 545 -2
+ Misses 102 87 -15
+ Partials 14 13 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
denopink
deleted the
denopink/refactoring/archive-webpa-common/logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included:
webpa-common#119go-kit/logwithzap#130go-kit/kit/metricswithprometheus/client_golang/prometheus#131Dependent on:
webpa common/logging,go-kit/logwithzapargus#333