docs: add no-nesting examples #120
Conversation
There was a problem hiding this comment.
Thanks for contributing these docs! Conceptually these look good, but could you please double check the invalid code examples to make sure the syntax is correct? I pasted the first example into the Prettier playground and was seeing a SyntaxError. Once that's resolved, this should be good to merge. 😄
docs/rules/no-nesting.md
Outdated
| ```js | ||
| myPromise | ||
| .then((val) => { | ||
| doSomething(val)) |
There was a problem hiding this comment.
Extra parenthesis at the end
There was a problem hiding this comment.
removed and formatted with prettier
docs/rules/no-nesting.md
Outdated
|
|
||
| myPromise | ||
| .then((val) => { | ||
| doSomething(val)) |
There was a problem hiding this comment.
Extra parenthesis at the end
There was a problem hiding this comment.
removed and formatted with prettier
docs/rules/no-nesting.md
Outdated
|
|
||
| myPromise | ||
| .catch((err) => { | ||
| doSomething(err)) |
There was a problem hiding this comment.
Extra parenthesis at the end
There was a problem hiding this comment.
removed and formatted with prettier
docs/rules/no-nesting.md
Outdated
|
|
||
| myPromise | ||
| .catch((err) => { | ||
| doSomething(err)) |
There was a problem hiding this comment.
Extra parenthesis at the end
There was a problem hiding this comment.
removed and formatted with prettier
ChristianMurphy
force-pushed
the
docs/no-nesting-examples
branch
from
8a02435
to
9918950
Compare
This Pull Request updates dependency [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from `v3.7.0` to `v3.8.0` <details> <summary>Release Notes</summary> ### [`v3.8.0`](https://github.com/xjamundx/eslint-plugin-promise/blob/master/CHANGELOG.md#​380) [Compare Source](eslint-community/eslint-plugin-promise@v3.7.0...v3.8.0) * Removed `promise/avoid-new` from recommended configuration ([#​119](`eslint-community/eslint-plugin-promise#119)) * Ignored event listener callbacks in `promise/prefer-await-to-callbacks` ([#​117](`eslint-community/eslint-plugin-promise#117)) * Ignored top-level awaits in `promise/prefer-await-to-then` ([#​126](`eslint-community/eslint-plugin-promise#126)) * Added docs for `promise/no-nesting` and `promise/prefer-await-to-then` ([#​120](`eslint-community/eslint-plugin-promise#120)) ([#​121](`eslint-community/eslint-plugin-promise#121)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Added valid and invalid examples to
no-nestingrule documentation