fix: ignore event listener callbacks in prefer-await-to-callbacks #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklinu
changed the title
macklinu
force-pushed
the
fix/event-callback-bug
branch
from
3f5d946
to
d0566dc
Compare
|
I amended the fix commit to ignore |
jimthedev
pushed a commit
to commitizen/cz-cli
that referenced
this pull request
May 25, 2018
This Pull Request updates dependency [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from `v3.7.0` to `v3.8.0` <details> <summary>Release Notes</summary> ### [`v3.8.0`](https://github.com/xjamundx/eslint-plugin-promise/blob/master/CHANGELOG.md#​380) [Compare Source](eslint-community/eslint-plugin-promise@v3.7.0...v3.8.0) * Removed `promise/avoid-new` from recommended configuration ([#​119](`eslint-community/eslint-plugin-promise#119)) * Ignored event listener callbacks in `promise/prefer-await-to-callbacks` ([#​117](`eslint-community/eslint-plugin-promise#117)) * Ignored top-level awaits in `promise/prefer-await-to-then` ([#​126](`eslint-community/eslint-plugin-promise#126)) * Added docs for `promise/no-nesting` and `promise/prefer-await-to-then` ([#​120](`eslint-community/eslint-plugin-promise#120)) ([#​121](`eslint-community/eslint-plugin-promise#121)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
This resolves #116, first checking if the callback function is supplied to an
emitter.on()function. This rule should ignore reporting on that case, IMO. Feedback welcome.