Coverage #196
Merged
Coverage #196
+9,857
−3,283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I need to wait until #195 may be merged into |
brettz9
force-pushed
the
coverage
branch
3 times, most recently
from
5f3b854 to
b0af281
Compare
brettz9
force-pushed
the
coverage
branch
3 times, most recently
from
1a6661d to
e70607a
Compare
- Testing: Fix test (was not parsing) - Testing: Fix test (missing an error message)
Also: - internally renames `isCallingBack` to `isCallback` as per file name and usage - removed code block from `always-return` which is not necessary given that "good" return/throw statements cannot occur within shortcut syntax (which expect expressions)
|
I personally don't care about 100% test coverage, but if we have it, let's try to keep it :D |
|
Cool--Appreciate the flexibility! FWIW, besides giving some assurances that edge cases have been considered and are working as expected, I find another advantage is ensuring self-documentation for others about what will happen under those edge case conditions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Testing coverage
What changes did you make? (Give an overview)
Builds on #195 (so that there would be a passing tests/linting baseline)
isCallingBacktoisCallbackas per file name and usageIn the process, this PR includes refactoring to remove dead code (and thereby avoid the need for
istanbul ignore):always-returnwhich is not necessary given that "good" return/throw statements cannot occur within shortcut syntax (which expect expressions)If you prefer that all of the code be refactored to avoid
istanbul ignore, I can do so, but I think the other code was more reasonable as a sanity guard (i.e., in case the code were ever refactored, those checks may be necessary).