Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #139: make it more clear that param-names includes ordering #143

Merged
merged 1 commit into from Aug 17, 2018

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Jul 13, 2018

Following up on discussion in #139, I think it might be good to explicitly call out the ordering aspect of param-names in your README table. It's clear when you read https://github.com/xjamundx/eslint-plugin-promise/blob/master/docs/rules/param-names.md, but I know I missed that when I only looked at the README summary.

@macklinu
Copy link
Contributor

Thanks for this! 🚢

@macklinu macklinu merged commit 24c4bd7 into eslint-community:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants