Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

檢查R2的目標命名空間 #229

Open
Xi-Plus opened this issue Jun 7, 2021 · 5 comments
Open

檢查R2的目標命名空間 #229

Xi-Plus opened this issue Jun 7, 2021 · 5 comments
Labels
Module: speedy Including image and speedy

Comments

@Xi-Plus
Copy link
Member

Xi-Plus commented Jun 7, 2021

Problem:
https://w.wiki/3SoV
https://w.wiki/3SoY
不防呆就犯蠢？

Proposal:

  1. 選取時使用<div>紅字顯示警告
  2. 送出時使用confirm()讓使用者確認是否繼續

Note:
討論一下具體方式，請先不要提交PR
@Xi-Plus Xi-Plus added the Module: speedy Including image and speedy label Jun 7, 2021
@hamishzx
Copy link
Collaborator

hamishzx commented Jun 7, 2021

@Xi-Plus personally tends to the second one, as many users including me, would ignore warning with no confirmation required

@Xi-Plus
Copy link
Member Author

Xi-Plus commented Jun 7, 2021

還有
3. 在可檢查目標命名空間的前提下，直接alert()並中止提刪

@hamishzx
Copy link
Collaborator

hamishzx commented Jun 7, 2021

按目前的情況，似乎也可以直接匹配方針，控制顯不顯示r2的選項在窗口內。

@Xi-Plus
Copy link
Member Author

Xi-Plus commented Jun 7, 2021

產生視窗的時候不會檢查頁面內容，若要這樣做會有額外的API請求。

@hamishzx
Copy link
Collaborator

hamishzx commented Jun 7, 2021 •
edited

按照speedy現狀的話，參考r3，直接用alert()會比較符合設計理念，吧？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module: speedy Including image and speedy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xi-Plus @hamishzx