Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build system should check whether pkg-config is installed #494

Closed
Yoric opened this issue Aug 23, 2018 · 5 comments
Closed

The build system should check whether pkg-config is installed #494

Yoric opened this issue Aug 23, 2018 · 5 comments

Comments

@Yoric
Copy link

Yoric commented Aug 23, 2018

I had a few difficulties building rav1e, which showed up as $git_desc being undefined in some Perl script. Turns out I had forgotten to install pkg-config.

It would be a bit nicer if the configure step could check that.

@lu-zero lu-zero added the bug label Aug 23, 2018
@lu-zero
Copy link
Collaborator

lu-zero commented Aug 23, 2018

pkg-config should do that already... How did you end up in that situation exactly?

@Yoric
Copy link
Author

Yoric commented Aug 23, 2018

I'm on macOS, I just ran

  1. git clone ...
  2. git submodule update --init
  3. cargo build

Here's the output:
backtrace.log

Installing pkg-config with homebrew seems to have fixed the issue.

@lu-zero
Copy link
Collaborator

lu-zero commented Aug 25, 2018

On readme we have:

In order to build, test and link to the codec on UNIX, you need Perl, Yasm, CMake, Clang and pkg-config. To install this on Ubuntu or Linux Mint, run:

sudo apt install perl yasm cmake clang pkg-config

On Windows, pkg-config is not required. A Perl distribution such as Strawberry Perl, CMake, and a Yasm binary in your system PATH are required.

Might be a good idea reporting to pkg-config that it should provide a friendlier error message.

@lu-zero
Copy link
Collaborator

lu-zero commented Aug 26, 2018

rust-lang/pkg-config-rs#56 is tracking this issue already.

@rzumer rzumer removed the bug label Nov 14, 2018
@rzumer
Copy link
Collaborator

rzumer commented Nov 14, 2018

Closing, as this should be fixed on pkg-config-rs's end if the error message is not displayed as expected (it should be, based on the probe() function).

@rzumer rzumer closed this as completed Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants