From 11e3b18c4c6c7190977629aefb7f0a79e1fbe31c Mon Sep 17 00:00:00 2001 From: Renovate Bot Date: Wed, 25 Aug 2021 07:12:41 +0000 Subject: [PATCH 1/2] fix: update dependency postcss-normalize-charset to v5 --- packages/postcss/package.json | 2 +- yarn.lock | 11 ++--------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/packages/postcss/package.json b/packages/postcss/package.json index ec580c942..b908c5ccb 100644 --- a/packages/postcss/package.json +++ b/packages/postcss/package.json @@ -29,7 +29,7 @@ "postcss": "^8.2.1", "postcss-import": "^14.0.0", "postcss-loader": "^6.1.0", - "postcss-normalize-charset": "^4.0.1", + "postcss-normalize-charset": "^5.0.0", "postcss-preset-env": "^6.7.0", "style-loader": "^3.0.0", "webpack": "5.46.0" diff --git a/yarn.lock b/yarn.lock index 458bac648..7635a63ae 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10595,14 +10595,7 @@ postcss-nesting@^7.0.0: dependencies: postcss "^7.0.2" -postcss-normalize-charset@^4.0.1: - version "4.0.1" - resolved "https://registry.yarnpkg.com/postcss-normalize-charset/-/postcss-normalize-charset-4.0.1.tgz#8b35add3aee83a136b0471e0d59be58a50285dd4" - integrity sha512-gMXCrrlWh6G27U0hF3vNvR3w8I1s2wOBILvA87iNXaPvSNo5uZAMYsZG7XjCUf1eVxuPfyL4TJ7++SGZLc9A3g== - dependencies: - postcss "^7.0.0" - -postcss-normalize-charset@^5.0.1: +postcss-normalize-charset@^5.0.0, postcss-normalize-charset@^5.0.1: version "5.0.1" resolved "https://registry.yarnpkg.com/postcss-normalize-charset/-/postcss-normalize-charset-5.0.1.tgz#121559d1bebc55ac8d24af37f67bd4da9efd91d0" integrity sha512-6J40l6LNYnBdPSk+BHZ8SF+HAkS4q2twe5jnocgd+xWpz/mx/5Sa32m3W1AA8uE8XaXN+eg8trIlfu8V9x61eg== @@ -10837,7 +10830,7 @@ postcss-values-parser@^2.0.0, postcss-values-parser@^2.0.1: indexes-of "^1.0.1" uniq "^1.0.1" -postcss@^7.0.0, postcss@^7.0.14, postcss@^7.0.17, postcss@^7.0.2, postcss@^7.0.32, postcss@^7.0.5, postcss@^7.0.6: +postcss@^7.0.14, postcss@^7.0.17, postcss@^7.0.2, postcss@^7.0.32, postcss@^7.0.5, postcss@^7.0.6: version "7.0.36" resolved "https://registry.yarnpkg.com/postcss/-/postcss-7.0.36.tgz#056f8cffa939662a8f5905950c07d5285644dfcb" integrity sha512-BebJSIUMwJHRH0HAQoxN4u1CN86glsrwsW0q7T+/m44eXOUAxSNdHRkNZPYz5vVUbg17hFgOQDE7fZk7li3pZw== From f6ebdf6fbb68bbcbaed25f89c70e28c054d82091 Mon Sep 17 00:00:00 2001 From: Robert Kowalski Date: Mon, 30 Aug 2021 14:21:15 +0200 Subject: [PATCH 2/2] fix(spec): remove invalid test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit previous versions of normalize-css did not log an error message, with this version error warnings are prited each time for invalid css. after double checking the bug reports in slack and also the initial PR, we came to the conclusion that we should default to print the error warning - especially as there is no "silent" option in normalize-css available. Co-authored-by: Björn Brauer --- .../integration/postcss/__tests__/build.js | 18 ------------------ packages/spec/integration/postcss/styles.css | 1 - 2 files changed, 19 deletions(-) delete mode 100644 packages/spec/integration/postcss/__tests__/build.js diff --git a/packages/spec/integration/postcss/__tests__/build.js b/packages/spec/integration/postcss/__tests__/build.js deleted file mode 100644 index 9ab95f3c6..000000000 --- a/packages/spec/integration/postcss/__tests__/build.js +++ /dev/null @@ -1,18 +0,0 @@ -/** - * @jest-hops-puppeteer off - */ - -describe('postcss - build', () => { - let stderr; - - beforeAll(async () => { - const result = await HopsCLI.build('-p', '--parallel-build'); - stderr = result.stderr; - }); - - it('should not output a @charset warning', () => { - expect(stderr).not.toContain( - 'postcss-import: @charset must precede all other statements' - ); - }); -}); diff --git a/packages/spec/integration/postcss/styles.css b/packages/spec/integration/postcss/styles.css index 073c7b916..3fa5ae151 100644 --- a/packages/spec/integration/postcss/styles.css +++ b/packages/spec/integration/postcss/styles.css @@ -1,6 +1,5 @@ @import url(imported-from-css.css); @import '@vishnucss/chips'; -@charset 'utf-8'; .headline { composes: compose from './for-composing.css';