Type inference for generic instance creation #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replacing type parameters with <>
ullenius
force-pushed
the
diamond-refactor
branch
2 times, most recently
from
b9241d2
to
1e398c5
Compare
The Java Language Specification and convention states that static ought to be listed before the final modifier (https://docs.oracle.com/javase/specs/jls/se11/html/jls-8.html#jls-8.1.1)
ullenius
force-pushed
the
diamond-refactor
branch
from
1e398c5
to
5f01d7b
Compare
gkorland
approved these changes
Nov 25, 2019
|
@ullenius Are these all? Did you look for more codes similar to the changes you have made? |
@sazzad16 I added 3 more commits fixing similar stuff. There are 2 more occurrences in ClusterScriptingCommandsTest that I did not change. And one in JedisTest. I'm somewhat reluctant to modify the tests given that they fail to pass as it is. |
|
@ullenius Let us know when you're done changing. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type inference for generic instance creation.
<T>with<>for inferred typeThis feature was added in Java 7 back in 2011 (!). The
pom.xmlexplicitly specifies Java 7 so this does not break anything.Minor refactoring:
Removing unused method parameter for private helper method
GenericObjectPoolConfig poolConfigis passed to the method but never usedDeclaring modifiers in recommended order (
static final)6fada2eReferences: Oracle docs