PipelineBase should not contain multi key operations #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PipelineBase should not 'look like' it contains multi key operations
|
@DvirDukhan PING! as you were the author of related PRs. |
gkorland
reviewed
Nov 25, 2019
| public Response<Object> sendCommand(ProtocolCommand cmd, String... args){ | ||
| String key = args.length > 0 ? args[0] : cmd.toString(); | ||
| getClient(key).sendCommand(cmd, args); | ||
| public Response<Object> sendCommand(final String sampleKey, final ProtocolCommand cmd, final String... args) { |
There was a problem hiding this comment.
@sazzad16 I think we should just deprecate these methods, once you have them in the MultiKeyPipelineBase you don't need these.
I don't think we need those for ShardedJedisPipeline or just move them there with the sample keys.
|
@sazzad16 I think we should also add these methods to the interfaces MultiKeyBinaryRedisPipeline and MultiKeyCommandsPipeline |
|
@gkorland MultiKeyBinaryRedisPipeline and MultiKeyCommandsPipeline contains actual Redis commands. Because of this conflict, we already have an open issue #2029 related to this. |
gkorland
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PipelineBase should not look like it contains multi key operations.
This is modification of #2007 and #2025