Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl zpopmin command #1988

Merged
merged 11 commits into from Oct 16, 2019
Merged

Impl zpopmin command #1988

merged 11 commits into from Oct 16, 2019

Conversation

kommradHomer
Copy link
Contributor

implemented zpopmin command.
written a test method

pom.xml Outdated Show resolved Hide resolved
@kommradHomer
Copy link
Contributor Author

removed the unnecessary plugin

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove only whitespace changes.

Also, it would be helpful if you could remove continuous empty lines from your code.

pom.xml Outdated Show resolved Hide resolved
@sazzad16 sazzad16 added this to the 3.1.0 milestone Jun 20, 2019
@sazzad16 sazzad16 requested a review from gkorland July 6, 2019 05:04
@gkorland
Copy link
Contributor

gkorland commented Jul 7, 2019

what about JedisClusterCommands?

@gkorland gkorland modified the milestones: 3.1.0, 3.2.0 Jul 14, 2019
@sazzad16 sazzad16 merged commit db338f1 into redis:master Oct 16, 2019
@SuShuilian
Copy link

I am looking forward to seeing this new command available in release version.
When will it be available in release version, any plan?

sazzad16 added a commit to sazzad16/jedis that referenced this pull request Dec 9, 2019
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Dec 9, 2019
@kommradHomer kommradHomer deleted the impl-zpopmin-command branch June 23, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants