Configure a Sentinel Connection when initialising the Sentinel pool #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karltinawi
changed the title
sazzad16
requested changes
Jan 29, 2019
- Removed the default password variable - Always initialise Jedis with password (null password is ignored) - Move sentinal parameters after client parameters
sazzad16
requested changes
Jan 29, 2019
- Added constructor to allow 'sentinelClientName'. - Use auth() and clientSetName() when creating Jedis to connect to sentinel - Removed newly added constructors from Jedis and BinaryJedis
sazzad16
requested changes
Jan 29, 2019
- Removed constructor the defaults sentinelClientName to 'null'. - Resolved 'tab' indentation - Moved all sentinel instance variables after 'master' variables.
sazzad16
approved these changes
Jan 30, 2019
|
Thanks @sazzad16. |
gkorland
reviewed
Jul 14, 2019
| protected String password; | ||
|
|
||
| protected int database = Protocol.DEFAULT_DATABASE; | ||
| protected int database; |
gkorland
reviewed
Jul 14, 2019
|
|
||
| protected String clientName; | ||
|
|
||
| protected int sentinelConnectionTimeout; | ||
| protected int sentinelSoTimeout; |
There was a problem hiding this comment.
should all these fields be final?
|
What is the holdup on this PR? Would be great to have this sometime |
gkorland
approved these changes
Nov 26, 2019
This was referenced Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to solve #1487 and #1636.
This PR adds a constructor to JedisSentinelPool to configure a Sentinel connection with respective timeout settings and a password. Supporting constructors have also been added to BinaryJedis and Jedis classes.
Thanks in advance for your review.