Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update supported versions #1917

Merged
merged 3 commits into from
Dec 19, 2018
Merged

update supported versions #1917

merged 3 commits into from
Dec 19, 2018

Conversation

gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland mentioned this pull request Dec 17, 2018
Closed
sazzad16
sazzad16 reviewed Dec 18, 2018
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we can add note like this

... there are still couple of new functionalities added Redis 5 missing in Jedis like Streams.

@gkorland
Copy link
Contributor Author

@sazzad16 comment added

sazzad16
sazzad16 approved these changes Dec 18, 2018
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcosnils marcosnils merged commit cfe01e3 into master Dec 19, 2018
@marcosnils marcosnils deleted the gkorland-supported-versions branch December 19, 2018 00:51
@gkorland gkorland added this to the 3.0.1 milestone Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

@marcosnils marcosnils Awaiting requested review from marcosnils

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkorland @sazzad16 @marcosnils