Reset timeout to initial value #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is apparently the most probable casue of issue that tempted the fix redis#1718.
|
@HeartSaVioR @marcosnils Please review this. Once timeout is set to 1 second, tests with 1+ seconds of sleep are tend to fail. Resetting timeout should resolve this issue. |
|
@marcosnils @gkorland Please review this. |
gkorland
suggested changes
Dec 18, 2018
| jedis.close(); | ||
|
|
||
| // reset config | ||
| jedis = new Jedis("localhost", 6379); |
There was a problem hiding this comment.
I think it should be in a try-finally block
| jedis.close(); | ||
|
|
||
| // reset config | ||
| jedis = new Jedis(new URI("redis://:foobared@localhost:6380/2")); |
There was a problem hiding this comment.
I think it should be in a try-finally block
|
@gkorland Just being lazy, but I think we can use |
LGTM!. Good catch @sazzad16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In two test methods, Redis config is changed but is not reset to initial value. Because of this,
redis.clients.jedis.exceptions.JedisConnectionException: Unexpected end of stream.occurs time to time in tests. This PR will resolve this issue.