Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing methods in RedisPipeline and BinaryRedisPipeline #1735

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Add missing methods in RedisPipeline and BinaryRedisPipeline #1735

merged 1 commit into from
Dec 17, 2018

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Jan 10, 2018 •
edited

Based on #1531, thanks to @PhantomThief

Closes #1531
Closes #1524

@sazzad16 sazzad16 added this to the 2.9.1 milestone Jan 10, 2018
@sazzad16
Copy link
Collaborator Author

@HeartSaVioR @marcosnils ?

@jiafu1115
Copy link
Contributor

LGTM @marcosnils

@sazzad16
Copy link
Collaborator Author

@marcosnils @gkorland ping

@gkorland gkorland modified the milestones: 2.9.1, 3.1.0 Dec 6, 2018
@gkorland gkorland self-requested a review December 6, 2018 12:10
@gkorland gkorland merged commit 95aa6a9 into redis:master Dec 17, 2018
@sazzad16 sazzad16 deleted the pull-1531 branch December 18, 2018 06:54
@gkorland
Copy link
Contributor

@sazzad16 do you think it should be part of 3.0.1

@sazzad16 sazzad16 modified the milestones: 3.1.0, 3.0.1 Dec 18, 2018
@sazzad16
Copy link
Collaborator Author

@gkorland OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkorland gkorland gkorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sazzad16 @jiafu1115 @gkorland