Fix Could not initialize class org.xerial.snappy.Snappy bug for MacOS
#265
Conversation
|
@xerial PTAL |
|
@asdf2014 It seems this issue is Mac OS X version specific issue. I'm using Mojave, and snappy-java works fine. What version of Mac OS X are you using? |
|
And also note that we've already dropped a support for Mac OS X 32-bit (x86), but it should work. So changing the library file name is not ideal for Mac/x86 |
|
Hi, @xerial . Thanks for your reply. I think this is a common problem on MacOS. I am using MacOS x86_64 and encountered this error. $ uname -a
Darwin yuzhouwan.com.local 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64 |
|
@asdf2014 Thanks for the update. Now I don't have an environment to use the latest Mac OS X, I need to confirm the true cause of this error. It seems you have added src/main/resources/org/xerial/snappy/native/Mac/x86_64/libsnappyjava.dylib file, but if we just rename the existing .jnilib file to .dylib, what will happen? I'd like to see the stack trace where the error occurs. If the error is still shown, it looks like the native library incompatibility problem between Mac OS X versions. |
|
@xerial In my environment, if I just rename |
|
@asdf2014 Ok. Then, could you fix the PR so that it will just rename libsnappyjava.jnilib to .dylib? After that, I'll merge it and release snappy-java-1.1.8.1 |
|
@xerial The useless |
|
LGTM. Thanks for the fix! |
|
@xerial You are welcome 😄 |
### What changes were proposed in this pull request? This upgrades snappy-java to 1.1.8.2. ### Why are the changes needed? Minor version upgrade that includes: - [Fixed](xerial/snappy-java#265) an initialization issue when using a recent Mac OS X version - Support Apple Silicon (M1, Mac-aarch64) - Fixed the pure-java Snappy fallback logic when no native library for your platform is found. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test. Closes #30690 from viirya/upgrade-snappy. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This upgrades snappy-java to 1.1.8.2. ### Why are the changes needed? Minor version upgrade that includes: - [Fixed](xerial/snappy-java#265) an initialization issue when using a recent Mac OS X version - Support Apple Silicon (M1, Mac-aarch64) - Fixed the pure-java Snappy fallback logic when no native library for your platform is found. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test. Closes #30690 from viirya/upgrade-snappy. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This upgrades snappy-java to 1.1.8.2. ### Why are the changes needed? Minor version upgrade that includes: - [Fixed](xerial/snappy-java#265) an initialization issue when using a recent Mac OS X version - Support Apple Silicon (M1, Mac-aarch64) - Fixed the pure-java Snappy fallback logic when no native library for your platform is found. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test. Closes #30695 from viirya/upgrade-snappy-3.1. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This upgrades snappy-java to 1.1.8.2. ### Why are the changes needed? Minor version upgrade that includes: - [Fixed](xerial/snappy-java#265) an initialization issue when using a recent Mac OS X version - Support Apple Silicon (M1, Mac-aarch64) - Fixed the pure-java Snappy fallback logic when no native library for your platform is found. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test. Closes #30697 from viirya/upgrade-snappy-2.4. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This upgrades snappy-java to 1.1.8.2. ### Why are the changes needed? Minor version upgrade that includes: - [Fixed](xerial/snappy-java#265) an initialization issue when using a recent Mac OS X version - Support Apple Silicon (M1, Mac-aarch64) - Fixed the pure-java Snappy fallback logic when no native library for your platform is found. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test. Closes #30698 from viirya/upgrade-snappy-3.0. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
No description provided.