Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool table instances to make PureJavaSnappy thread safe #271

Merged
merged 1 commit into from Jan 20, 2021

Conversation

bokken
Copy link
Contributor

@bokken bokken commented Dec 2, 2020

This fixes #270

@xerial xerial self-assigned this Dec 7, 2020
table);
compressed.position(compressed.position() + written);
return written;
final short[] table = getTable();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not need to be obtained from within the synchronized blocks

@bokken
Copy link
Contributor Author

bokken commented Jan 20, 2021

@xerial any idea when we can get this fix released?
I just ran into an issue where the pure java implementation was used unexpectedly (directory permission issues where lib was extracted) and it resulted in corrupt content (rather than the previous failure if lib could not be loaded).

@xerial xerial merged commit 110727e into xerial:master Jan 20, 2021
@xerial
Copy link
Owner

xerial commented Jan 20, 2021

I'm now preparing 1.1.8.3, including the CRC32 improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PureJavaSnappy is not thread-safe
2 participants