feat: add BatchExternalContact #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen0n
reviewed
Jan 28, 2021
external_contact.go
Outdated
| @@ -26,6 +26,19 @@ func (c *WorkwxApp) GetExternalContact(externalUserid string) (*ExternalContactI | |||
| return &resp.ExternalContactInfo, nil | |||
| } | |||
|
|
|||
| // BatchExternalContact 批量获取客户详情 | |||
| func (c *WorkwxApp) BatchExternalContact(userID, cursor string, limit int) ([]ExternalContactBatchInfo, string, error) { | |||
There was a problem hiding this comment.
Batchis not a verb, use something likeBatchListExternalContactswould be better IMOa, b Typeis not allowed in this repo (like described in this article), duplicating thestringpart is fine for readability- returning three values is not ergonomic, make a wrapper struct for that is fine
There was a problem hiding this comment.
Like the following
type BatchListExternalContactsResp struct {
Result []ExternalContactBatchInfo
NextCursor string
}P.S. the ExternalContactBatchInfo name is very unfortunate but I cannot come up with a better one, so leave it alone for now...
There was a problem hiding this comment.
give a friendly remind, Batch is a verb
There was a problem hiding this comment.
Hah, I forgot it!
Though the "batch" verb is more suited to "batching requests" and such, it doesn't have the "list" meaning implied.
|
LGTM overall, thanks for the contribution! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BatchExternalContact doc: https://work.weixin.qq.com/api/doc/90000/90135/92994