add method SendTaskCardMessage #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen0n
reviewed
Jan 7, 2021
models.go
Outdated
Comment on lines
944
to
948
| Key string `json:"key"` | ||
| Name string `json:"name"` | ||
| ReplaceName string `json:"replace_name"` | ||
| Color string `json:"color"` | ||
| IsBold bool `json:"is_bold"` |
There was a problem hiding this comment.
Add field descriptions from official docs.
message.go
Outdated
Comment on lines
201
to
209
| btnByte, err := json.Marshal(btn) | ||
| if err != nil { | ||
| return errors.New("btn convert to json fail: " + err.Error()) | ||
| } | ||
| var btnSlice []map[string]interface{} | ||
| err = json.Unmarshal(btnByte, &btnSlice) | ||
| if err != nil { | ||
| return errors.New("btn convert to []map fail: " + err.Error()) | ||
| } |
There was a problem hiding this comment.
This shouldn't be necessary, a []TaskCardBtn is an interface{} after all, there's no custom marshaling logic at play.
xen0n
approved these changes
Jan 7, 2021
|
Build succeeded:
|
jioswu
pushed a commit
to jioswu/go-workwx
that referenced
this pull request
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加了发送任务卡片类型的消息