Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Inconsistent line coverage errors. #1083

Open
JosiahBull opened this issue Aug 27, 2022 · 1 comment
Open

[BUG] - Inconsistent line coverage errors. #1083

JosiahBull opened this issue Aug 27, 2022 · 1 comment
Assignees
Labels

Comments

@JosiahBull
Copy link

Describe the bug
I've been seeing inconsistent coverage.

Screenshot from 2022-08-27 20-09-36

Note that this error is positional for some reason. Swapping the impl for CommError with Auth means the error appears on Auth instead.

Tagging #351 , though it may be user error at this point so don't want to add to that thread right away.

To Reproduce

git clone https://github.com/riptide-org/ws-com-framework/
cd ws-com-framework
cargo tarpaulin --out lov --all #version 0.20.1

Expected behavior
I expected the line coverage to be consistent for the TryFrom implementation.

@xd009642
Copy link
Owner

If you were using llvm coverage this should be improved in the latest release. If you're using ptrace it's potentially unavoidable - there's a bunch of concurrency nightmares with tracing multi-threaded applications which make consistency maybe impossible. Things like --test-threads 1 is an answer.

Sorry for not getting back sooner, I'll keep this issue open if you want to check back in. But otherwise I'll likely close in a month or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants