Add auto_ssl_enabled to Pages Domain #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexives
commented
Feb 9, 2020
|
For more details on auto ssl, see https://docs.gitlab.com/ee/user/project/pages/custom_domains_ssl_tls_certification/lets_encrypt_integration.html |
svanharmelen
requested changes
Feb 9, 2020
There was a problem hiding this comment.
Thanks @alexives! Please follow up on the minor feedback, after which I'll be happy to merge your PR.
alexives
force-pushed
the
add_auto_ssl_option_to_pages_domain
branch
from
972913d
to
5635223
Compare
|
Wow! Thanks for your fast feedback! Those changes are up now! |
svanharmelen
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto_ssl_enabled option was added in gitlab 12.1 and I'd like to have it here! Let me know what I need to do to get this in!