approval state of merge requests #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
requested changes
Feb 6, 2020
| ContainsHiddenGroups bool `json:"contains_hidden_groups"` | ||
| ApprovedBy []*BasicUser `json:"approved_by"` | ||
| Approved bool `json:"approved"` | ||
| } |
There was a problem hiding this comment.
Let's not create a new struct, but instead add the missing fields to the MergeRequestApprovalRule struct and reuse that one here.
merge_request_approvals.go
Outdated
| return nil, nil, err | ||
| } | ||
|
|
||
| var par *MergeRequestApprovalState |
There was a problem hiding this comment.
Maybe call this pas, for this is about the state, not a rule?
Suggested change
| var par *MergeRequestApprovalState | |
| var pas *MergeRequestApprovalState |
|
I addressed both comments. Let me know if you want any other changes. Thanks |
|
Thanks for doing this. I made an ugly vendor patch downstream but didnt have time to merge back |
svanharmelen
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Support for getting the approval state of merge requests
https://docs.gitlab.com/ee/api/merge_request_approvals.html#get-the-approval-state-of-merge-requests