add system hook events #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
force-pushed
the
issue-622
branch
from
df12513
to
0411282
Compare
|
@itscaro sorry for my super late response to this PR! I rebased the PR and added a commit to make it (IMHO) more inline with the rest of the code in this package. Can you confirm that the updated code works as expected and fits your needs? When you can confirm the PR still works for you, I will merge it and release a new version. |
svanharmelen
force-pushed
the
issue-622
branch
from
0411282
to
aa38293
Compare
Signed-off-by: Minh-Quan TRAN <account@itscaro.me>
|
@svanharmelen I rebased on top of master, everything seems working fine |
|
Again, thanks @itscaro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #622
I moved all fixtures out into json files stored in testdata.