Fix slow tests caused by retry backoff #1598

armsnyder · 2022-12-11T21:37:17Z

I disabled retry backoffs in tests to reduce the overall test run time from 25 seconds to under 1 second.

Before:

% ~/go/bin/gotestsum --jsonfile out.json
✓  . (25.685s)
% ~/go/bin/gotestsum tool slowest --jsonfile out.json
github.com/xanzy/go-gitlab TestInstanceClustersService_AddCluster_StatusInternalServerError 12.08s
github.com/xanzy/go-gitlab TestInstanceVariablesService_StatusInternalServerError 11.73s
github.com/xanzy/go-gitlab TestUploadFile_Retry 710ms
github.com/xanzy/go-gitlab TestUploadAvatar_Retry 710ms

After:

% ~/go/bin/gotestsum --jsonfile out.json
✓  . (425ms)
% ~/go/bin/gotestsum tool slowest --jsonfile out.json

gitlab_test.go

svanharmelen

I've taken another look at the involved tests and guess you are right... So I'll take it... 👍🏻

Fix slow tests by disabling retry backoff

21ae872

svanharmelen suggested changes Dec 12, 2022

View reviewed changes

gitlab_test.go Show resolved Hide resolved

svanharmelen approved these changes Dec 12, 2022

View reviewed changes

svanharmelen merged commit 52eedaa into xanzy:master Dec 12, 2022

armsnyder deleted the fix-slow-tests branch December 12, 2022 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix slow tests caused by retry backoff #1598

Fix slow tests caused by retry backoff #1598

armsnyder commented Dec 11, 2022 •

edited

Loading

svanharmelen left a comment

Fix slow tests caused by retry backoff #1598

Fix slow tests caused by retry backoff #1598

Conversation

armsnyder commented Dec 11, 2022 • edited Loading

svanharmelen left a comment

Choose a reason for hiding this comment

armsnyder commented Dec 11, 2022 •

edited

Loading