Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref to deployment webhook #1565

Merged
merged 2 commits into from Oct 29, 2022
Merged

Conversation

vntw
Copy link
Contributor

@vntw vntw commented Oct 19, 2022

Hey 馃憢,

ref seems to be undocumented in the deployment webhook event docs, but looking at the code, it's always present: https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/data_builder/deployment.rb#L44.

Just as another example, deploying from sth. else than a tag will contain sth. like "ref":"refs/merge-requests/1/merge". I tested this with the GitLab SaaS version.

I also updated the docs URL for the job event since the TODO comment was from 2019 馃檪

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 馃憤馃徎 LGTM!

@svanharmelen svanharmelen merged commit 1114045 into xanzy:master Oct 29, 2022
@vntw vntw deleted the deploy-hook-ref branch October 30, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants