Add support to protect tags with group_id or user_id #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svanharmelen would you be able to review this? I'm hoping get this updated so that I can get a downstream issue resolved |
svanharmelen
requested changes
Oct 27, 2022
protected_tags.go
Outdated
| @@ -46,6 +46,8 @@ type ProtectedTag struct { | |||
| type TagAccessDescription struct { | |||
| AccessLevel AccessLevelValue `json:"access_level"` | |||
| AccessLevelDescription string `json:"access_level_description"` | |||
| UserID *int `url:"user_id,omitempty" json:"user_id,omitempty"` | |||
| GroupID *int `url:"group_id,omitempty" json:"group_id,omitempty"` | |||
There was a problem hiding this comment.
I cannot see in the docs that these fields need to be here. Can you point me to somewhere (in the code) that shows these fields exist in this struct?
Additionally in a response struct like this we don't use pointers for build-in types and URL tags.
protected_tags.go
Outdated
| // | ||
| // GitLab API docs: | ||
| // https://docs.gitlab.com/ee/api/protected_tags.html#protect-repository-tags | ||
| type ProtectRepositoryTagsPermissionOptions struct { |
There was a problem hiding this comment.
Maybe make this just a little shorter, like TagsPermissionOptions or something?
protected_tags.go
Outdated
| CreateAccessLevel *AccessLevelValue `url:"create_access_level,omitempty" json:"create_access_level,omitempty"` | ||
| Name *string `url:"name" json:"name"` | ||
| CreateAccessLevel *AccessLevelValue `url:"create_access_level,omitempty" json:"create_access_level,omitempty"` | ||
| AllowedToCreate *[]ProtectRepositoryTagsPermissionOptions `url:"allowed_to_create,omitempty" json:"allowed_to_create,omitempty"` |
There was a problem hiding this comment.
Suggested change
| AllowedToCreate *[]ProtectRepositoryTagsPermissionOptions `url:"allowed_to_create,omitempty" json:"allowed_to_create,omitempty"` | |
| AllowedToCreate *[]*ProtectRepositoryTagsPermissionOptions `url:"allowed_to_create,omitempty" json:"allowed_to_create,omitempty"` |
svanharmelen
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1511