Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Group SAML Links #1527

Merged
merged 3 commits into from Aug 21, 2022
Merged

Add Group SAML Links #1527

merged 3 commits into from Aug 21, 2022

Conversation

mhodgson
Copy link
Contributor

Gitlab Group SAML Group links added to production API yesterday:
https://docs.gitlab.com/ee/api/groups.html#saml-group-links

@mhodgson mhodgson mentioned this pull request Aug 16, 2022
Closed
1 task
@mhodgson
Copy link
Contributor Author

Downstream Terraform Provider Update: gitlabhq/terraform-provider-gitlab#1215

timofurrer
timofurrer reviewed Aug 16, 2022
View reviewed changes
groups.go
//
// GitLab API docs:
// https://docs.gitlab.com/ee/api/groups.html#list-saml-group-links
func (s *GroupsService) ListGroupSAMLLinks(gid interface{}, options ...RequestOptionFunc) ([]*SAMLGroupLink, *Response, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this endpoint support pagination?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, just confirmed with live testing in Postman.

@timofurrer
Copy link
Contributor

I've just created a MR upstream on GitLab to improve a few things for this API, seehttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/95561 - including:

  • fixing a bug which lead to an empty response when creating a new SAML Group Link
  • implemented a get endpoint to retrieve information for a single SAML Group Link

@timofurrer
Copy link
Contributor

@mhodgson little update: my MR to the API from this morning was merged a few hours ago. Thus, I think you can implement it accordingly :)

@mhodgson
Copy link
Contributor Author

@timofurrer awesome! Do you know when this would be in production? We're hoping to use this sooner than later...

@mhodgson
Copy link
Contributor Author

@timofurrer I updated the code here to account for your upstream changes.

@timofurrer
Copy link
Contributor

@timofurrer awesome! Do you know when this would be in production? We're hoping to use this sooner than later...

@mhodgson It's already available on gitlab.com, see: https://docs.gitlab.com/ee/api/groups.html#get-saml-group-link

And it will come to the self-hosted version with GitLab 15.3 - which means that I'll try to get a release out of the terraform provider on either the 22nd or 23rd - right after 15.3 comes out.

timofurrer
timofurrer approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@mhodgson
Copy link
Contributor Author

mhodgson commented Aug 17, 2022 •
edited

@timofurrer are you sure the changes are live? I'm testing the create endpoint and still getting a null response. The GET endpoint also returns 404 for all requests, so thinking that isn't live either.

@timofurrer
Copy link
Contributor

@timofurrer are you sure the changes are live? I'm testing the create endpoint and still getting a null response. The GET endpoint also returns 404 for all requests, so thinking that isn't live either.

Interesting 🤔 I just assumed because the docs are live - it must be available "soon" ™️

@mhodgson
Copy link
Contributor Author

@timofurrer looks like the updates are live! LGTM.

svanharmelen
svanharmelen approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires a few small tweaks which I will add in a separate commit...

@svanharmelen svanharmelen merged commit 301e201 into xanzy:master Aug 21, 2022
@svanharmelen
Copy link
Member

svanharmelen commented Aug 21, 2022 •
edited

Thanks for your PR @mhodgson! Please see this commit for the last bits that you missed: 88c4146

timofurrer added a commit to timofurrer/go-gitlab that referenced this pull request Aug 23, 2022
@timofurrer
Fix SAML Group Links Access Level type
c6383e6 
While working on gitlabhq/terraform-provider-gitlab#1215
I have noticed that the access level type introcued in
xanzy#1527
is wrong.
@timofurrer timofurrer mentioned this pull request Aug 23, 2022
Merged
gravis pushed a commit to gravis/go-gitlab that referenced this pull request Sep 1, 2022
@timofurrer @gravis
Fix SAML Group Links Access Level type
3e8acaa 
While working on gitlabhq/terraform-provider-gitlab#1215
I have noticed that the access level type introcued in
xanzy#1527
is wrong.
gravis pushed a commit to gravis/go-gitlab that referenced this pull request Sep 1, 2022
@timofurrer @gravis
Fix SAML Group Links Access Level type
d3055f8 
While working on gitlabhq/terraform-provider-gitlab#1215
I have noticed that the access level type introcued in
xanzy#1527
is wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timofurrer timofurrer timofurrer approved these changes

@svanharmelen svanharmelen svanharmelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhodgson @timofurrer @svanharmelen