Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another GPG API #1512

Merged
merged 1 commit into from Jul 30, 2022
Merged

Fix another GPG API #1512

merged 1 commit into from Jul 30, 2022

Conversation

yan12125
Copy link

Following up #1509. This is also noticed when I'm working on https://github.com/gitlabhq/terraform-provider-gitlab/issues/1166. Probably GPG APIs should be properly tested.

Copy link
Contributor

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify if any other GPG related APIs are also wrong?

@yan12125
Copy link
Author

I only check by eyes and they look correct.

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yan12125!

@svanharmelen svanharmelen merged commit 68d692c into xanzy:master Jul 30, 2022
@yan12125 yan12125 deleted the fix-gpg-key-apis-2 branch July 30, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants