Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issues): iteration field, search by iteration #1505

Merged
merged 1 commit into from Jul 15, 2022

Conversation

lizalc
Copy link
Contributor

@lizalc lizalc commented Jul 14, 2022

Add missing Iteration field to Issue struct and support searching by
iteration ID.

Add tests for new features.


I've been using these changes for a work project for a few days now without issue.

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small style comments...

issues_test.go Outdated
Comment on lines 326 to 328
}
func TestListIssuesSearchByIterationID(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
func TestListIssuesSearchByIterationID(t *testing.T) {
}
func TestListIssuesSearchByIterationID(t *testing.T) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

issues_test.go Outdated
Comment on lines 380 to 383
}
func TestListProjectIssues(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
func TestListProjectIssues(t *testing.T) {
}
func TestListProjectIssues(t *testing.T) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

issues_test.go Outdated
Comment on lines 410 to 414
}
func TestListProjectIssuesSearchByIterationID(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
func TestListProjectIssuesSearchByIterationID(t *testing.T) {
}
func TestListProjectIssuesSearchByIterationID(t *testing.T) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

issues_test.go Outdated
Comment on lines 497 to 502
}
func TestListGroupIssuesSearchByIterationID(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
func TestListGroupIssuesSearchByIterationID(t *testing.T) {
}
func TestListGroupIssuesSearchByIterationID(t *testing.T) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Add missing Iteration field to Issue struct and support searching by
iteration ID.

Add tests for new features.
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏻

@svanharmelen svanharmelen merged commit 498b5f5 into xanzy:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants