New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issues): iteration field, search by iteration #1505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small style comments...
issues_test.go
Outdated
} | ||
func TestListIssuesSearchByIterationID(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
func TestListIssuesSearchByIterationID(t *testing.T) { | |
} | |
func TestListIssuesSearchByIterationID(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
issues_test.go
Outdated
} | ||
func TestListProjectIssues(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
func TestListProjectIssues(t *testing.T) { | |
} | |
func TestListProjectIssues(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
issues_test.go
Outdated
} | ||
func TestListProjectIssuesSearchByIterationID(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
func TestListProjectIssuesSearchByIterationID(t *testing.T) { | |
} | |
func TestListProjectIssuesSearchByIterationID(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
issues_test.go
Outdated
} | ||
func TestListGroupIssuesSearchByIterationID(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
func TestListGroupIssuesSearchByIterationID(t *testing.T) { | |
} | |
func TestListGroupIssuesSearchByIterationID(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Add missing Iteration field to Issue struct and support searching by iteration ID. Add tests for new features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍🏻
Add missing Iteration field to Issue struct and support searching by
iteration ID.
Add tests for new features.
I've been using these changes for a work project for a few days now without issue.