Add support for merged YAML return from linter #1497
Conversation
validate.go
Outdated
| } | ||
|
|
||
| return l, resp, nil | ||
| } |
There was a problem hiding this comment.
Instead of making a dedicated function like this the general approach is to make an option struct and pass that into the existing Lint function.
I do notice that the existing Lint function already does this different, but the best way forward is to correct that (now that it caught my eye 😉) instead of repeating it...
There was a problem hiding this comment.
Would you prefer I make an entirely new function to maintain backward compatibility? Like LintWithOptions or something?
There was a problem hiding this comment.
Thanks @robbydyer! I updated the PR so your version replaces the incomplete Lint function that already existed.
I understand this is now a breaking change, but the old version was clearly not implemented correctly (not following the actual API) so in this case I am good with that...
The lint API requires setting the
include_merged_yamloption to true to in order for it to return the merged YAML. Since the existingLintfunction doesn't take options as a parameter, this adds a new function that sets that option to true. https://docs.gitlab.com/ee/api/lint.html#validate-the-ci-yaml-configuration