Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransferSubGroup to transfer a group to a new parent group #1468

Merged
merged 5 commits into from May 10, 2022

Conversation

gro-gg
Copy link
Contributor

@gro-gg gro-gg commented May 9, 2022

this fixes #1466

@gro-gg
Copy link
Contributor Author

gro-gg commented May 9, 2022

@svanharmelen

I have moved a group back and forth with this test:

package gitlab

import (
	"fmt"
	"os"
	"testing"
)

func TestName(t *testing.T) {
	parent1 := 52852274
	//parent2 := 52852276
	child := 52852277
	token := os.Getenv("GITLAB_TOKEN_RW")
	client, err := NewClient(token)
	if err != nil {
		t.Fatal(err)
	}

	opt := &TransferSubGroupOptions{
		ParentID: Int(parent1),
	}

	group, response, err := client.Groups.TransferSubGroup(child, opt)
	if err != nil {
		t.Fatal(err)
	}
	fmt.Println(group)
	fmt.Println(response)
}

groups.go Outdated Show resolved Hide resolved
groups.go Outdated Show resolved Hide resolved
gro-gg and others added 3 commits May 10, 2022 11:17
Co-authored-by: Sander van Harmelen <sander@vanharmelen.nl>
Co-authored-by: Sander van Harmelen <sander@vanharmelen.nl>
@gro-gg gro-gg requested a review from svanharmelen May 10, 2022 09:27
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close 😉

groups.go Outdated Show resolved Hide resolved
Co-authored-by: Sander van Harmelen <sander@vanharmelen.nl>
@gro-gg gro-gg requested a review from svanharmelen May 10, 2022 09:48
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gro-gg 👍🏻

@svanharmelen svanharmelen merged commit 3da4509 into xanzy:master May 10, 2022
@gro-gg
Copy link
Contributor Author

gro-gg commented May 10, 2022

🙇 Thanks for reviewing and merging!

@svanharmelen When do you plan to release a new version? 😊
I need this new feature in: gro-gg/terraform-provider-gitlab@5387a58

@svanharmelen
Copy link
Member

Just released v0.65.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for transfer a group to a new parent group
2 participants