Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added vulnerabilities #1448

Merged
merged 3 commits into from Apr 22, 2022
Merged

added vulnerabilities #1448

merged 3 commits into from Apr 22, 2022

Conversation

rotiv13
Copy link
Contributor

@rotiv13 rotiv13 commented Apr 11, 2022

No description provided.

@rotiv13
Copy link
Contributor Author

rotiv13 commented Apr 11, 2022

Just seeing if it possible to get implemented the vulnerabilities for each repo.

@rotiv13 rotiv13 force-pushed the add-vulnerabilities branch 2 times, most recently from bc8aeec to f76d127 Compare April 11, 2022 11:01
@svanharmelen svanharmelen marked this pull request as draft April 11, 2022 11:05
@svanharmelen
Copy link
Member

Made this a draft PR as you also updated the go.mod file to point at your own fork... Additionally (as a premature review comment) the field types of the struct should not be interface{}, so please make sure they are of the correct type before finishing the PR. Thanks!

@rotiv13
Copy link
Contributor Author

rotiv13 commented Apr 11, 2022

Made this a draft PR as you also updated the go.mod file to point at your own fork... Additionally (as a premature review comment) the field types of the struct should not be interface{}, so please make sure they are of the correct type before finishing the PR. Thanks!

Yep makes sense. Thank you for the comment. I am basically experimenting with this and seeing if it is possible to get the vulnerabilities of a project. I will make it better once I see that everything is ready.

@rotiv13 rotiv13 force-pushed the add-vulnerabilities branch 4 times, most recently from d2b8127 to b39ad47 Compare April 11, 2022 17:40
@rotiv13 rotiv13 marked this pull request as ready for review April 12, 2022 10:25
@rotiv13
Copy link
Contributor Author

rotiv13 commented Apr 14, 2022

@svanharmelen if you can do a review when you have some time.

svanharmelen
svanharmelen approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rotiv13! Tweaked a few small things, but looks good otherwise 👍🏻

@svanharmelen svanharmelen merged commit 259de56 into xanzy:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanharmelen svanharmelen svanharmelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rotiv13 @svanharmelen