New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GitPod support #1423
base: main
Are you sure you want to change the base?
Adding GitPod support #1423
Conversation
@svanharmelen Ready for review when you have time |
@svanharmelen I would say yes both are good and work in conjunction with each other vs one being a replacement for the other. This is used for development but you can also run the acceptance tests in a GitPod if you desire. The only duplication that currently exists between the 2 PR's are the container startup scripts and either PR can go first as they should be basically identical. |
@svanharmelen We can merge this and it will be combined and coincide with the work done on #1392 |
I'm going to wait with this one until I heart back from GitLab (I am talking with them about this repo)... |
@svanharmelen Is that true of all pull requests on this repo or just ones pertaining to ease of development? |
@Shocktrooper as you probably already noticed, it's only true for PRs that introduce new "concepts". PRs that contain bugfixes or that add missing or new APIs will still be reviewed and merged. And once I have more clarity about the future of this repo, I (or someone else) will have a look at these ones as well! |
Resolves #1422