Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GitPod support #1423

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding GitPod support #1423

wants to merge 3 commits into from

Conversation

Shocktrooper
Copy link
Contributor

Resolves #1422

@Shocktrooper
Copy link
Contributor Author

@svanharmelen Ready for review when you have time

@svanharmelen
Copy link
Member

How (if at all) does this related to #1392? Of is this only used for development where the solution in #1392 is only used for acceptance tests?

Just trying to understand if we need both these approaches for this package...

@Shocktrooper
Copy link
Contributor Author

@svanharmelen I would say yes both are good and work in conjunction with each other vs one being a replacement for the other. This is used for development but you can also run the acceptance tests in a GitPod if you desire. The only duplication that currently exists between the 2 PR's are the container startup scripts and either PR can go first as they should be basically identical.

@Shocktrooper
Copy link
Contributor Author

@svanharmelen We can merge this and it will be combined and coincide with the work done on #1392

@svanharmelen
Copy link
Member

I'm going to wait with this one until I heart back from GitLab (I am talking with them about this repo)...

@Shocktrooper
Copy link
Contributor Author

@svanharmelen Is that true of all pull requests on this repo or just ones pertaining to ease of development?

@svanharmelen
Copy link
Member

@Shocktrooper as you probably already noticed, it's only true for PRs that introduce new "concepts". PRs that contain bugfixes or that add missing or new APIs will still be reviewed and merged.

And once I have more clarity about the future of this repo, I (or someone else) will have a look at these ones as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gitpod support to be able to open up a preconfigured development workspace for this library
2 participants