feat(snippets): Add files array to snippet creation
#1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
requested changes
Feb 10, 2022
snippets.go
Outdated
| @@ -111,6 +124,7 @@ type CreateSnippetOptions struct { | |||
| Description *string `url:"description,omitempty" json:"description,omitempty"` | |||
| Content *string `url:"content,omitempty" json:"content,omitempty"` | |||
| Visibility *VisibilityValue `url:"visibility,omitempty" json:"visibility,omitempty"` | |||
| Files []*SnippetFile `url:"files,omitempty" json:"files,omitempty"` | |||
There was a problem hiding this comment.
I know this seems weird, but this needs to be *[]*SnippetFile to keep it consistent with the rest of the package.
There was a problem hiding this comment.
That makes sense. Fixed up both of the places.
project_snippets.go
Outdated
| @@ -94,6 +94,7 @@ type CreateProjectSnippetOptions struct { | |||
| Description *string `url:"description,omitempty" json:"description,omitempty"` | |||
| Content *string `url:"content,omitempty" json:"content,omitempty"` | |||
| Visibility *VisibilityValue `url:"visibility,omitempty" json:"visibility,omitempty"` | |||
| Files []*SnippetFile `url:"files,omitempty" json:"files,omitempty"` | |||
There was a problem hiding this comment.
I know this seems weird, but this needs to be *[]*SnippetFile to keep it consistent with the rest of the package.
This adds the new `files` array for creating snippets that replaces the now deprecated `filename` and `contents` keys. This is needed for creating more then one file in snippets. Issue xanzy#1372
zemzale
force-pushed
the
feat-new-snippet-api
branch
from
65aab58
to
9e398b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new
filesarray for creating snippets that replaces thenow deprecated
filenameandcontentskeys.This is needed for creating more then one file in snippets.
Issue #1372