Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update README.md #1348

Merged
merged 1 commit into from Jan 24, 2022
Merged

update README.md #1348

merged 1 commit into from Jan 24, 2022

Conversation

jackcipher
Copy link
Contributor

@jackcipher jackcipher commented Jan 24, 2022 •
edited

Hi,

  1. "GitLab" is a proper noun. Original style should be kept when referencing.
  2. Comma should be added after a conjunctive adverb, such as "currently".

svanharmelen
svanharmelen reviewed Jan 24, 2022
View reviewed changes
README.md
This API client package covers most of the existing Gitlab API calls and is updated regularly
to add new and/or missing endpoints. Currently the following services are supported:
This API client package covers most of the existing GitLab API calls and is updated regularly
to add new and/or missing endpoints. Currently, the following services are supported:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with updating the name GitLab, but are you 100% sure this comma needs to be here? Or is it optional depending on the rest of the sentense?

As to me it reads a bit strange this way, yet I'm a non-native English speaker so I'm not positive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When "currently" is the introductory word at the beginning of a sentence, you need a comma after it. See more

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll take it... Thanks.

@svanharmelen svanharmelen merged commit 323c2d8 into xanzy:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanharmelen svanharmelen svanharmelen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackcipher @svanharmelen