Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add None and Any options for AssigneeID for all merge request list fu… #1335

Merged
merged 2 commits into from Jan 5, 2022

Conversation

Bouwdie
Copy link
Contributor

@Bouwdie Bouwdie commented Jan 4, 2022

Add None and Any options for AssigneeID for all merge request list functions.
Fixes #751

Bouwdie and others added 2 commits January 4, 2022 21:16
…nctions.

Fixes xanzy#751

The fix that has been added implement a type just like we do for AssigneeIDs. A value object that encapsulates the possible values. This is a backwards breaking fix.
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it a little more generic and also added ReviewerID. But otherwise looks good 👍🏻

@svanharmelen svanharmelen merged commit 3d128ad into xanzy:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssigneeID should not be *int
2 participants