Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: add ProjectID to pipeline structure #1187

Merged
merged 1 commit into from Aug 11, 2021
Merged

pipeline: add ProjectID to pipeline structure #1187

merged 1 commit into from Aug 11, 2021

Conversation

bmeneg
Copy link

@bmeneg bmeneg commented Aug 10, 2021

The "project_id" information is returned from the pipeline API endpoint
since GitLab 13 (not sure the minor version), but go-gitlab Pipeline and
PipelineInfo wasn't storing it. Add it to both structures.

Signed-off-by: Bruno Meneguele bmeneg@redhat.com

The "project_id" information is returned from the pipeline API endpoint
since GitLab 13 (not sure the minor version), but go-gitlab Pipeline and
PipelineInfo wasn't storing it. Add it to both structures.

Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bmeneguele!

@svanharmelen svanharmelen merged commit 175c949 into xanzy:master Aug 11, 2021
@bmeneg
Copy link
Author

bmeneg commented Aug 11, 2021

@svanharmelen tyvm.

Would you mind releasing a new go-gitlab version for picking this change?
Sorry if I'm being invasive.. not sure if you follow a release schedule.

@svanharmelen
Copy link
Member

I don't follow a specific release schedule, so just added a tag 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants