Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Access Token access level #1178

Merged
merged 1 commit into from Jul 21, 2021
Merged

Project Access Token access level #1178

merged 1 commit into from Jul 21, 2021

Conversation

M0roSan
Copy link

@M0roSan M0roSan commented Jul 17, 2021

close #1175

adding access_level support for project access token.

svanharmelen
svanharmelen requested changes Jul 19, 2021
View reviewed changes
project_access_tokens.go Outdated Show resolved Hide resolved
svanharmelen
svanharmelen reviewed Jul 19, 2021
View reviewed changes
project_access_tokens.go Outdated Show resolved Hide resolved
project_access_tokens_test.go Outdated Show resolved Hide resolved
svanharmelen
svanharmelen reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

project_access_tokens.go Outdated Show resolved Hide resolved
Project Access Token access level
4fca837 
use custom type

accesslevel optional field

returned value
svanharmelen
svanharmelen approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with me @M0roSan! LGTM 🎉

@svanharmelen svanharmelen merged commit 966fbad into xanzy:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanharmelen svanharmelen svanharmelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for project access token's access level
2 participants
@M0roSan @svanharmelen