You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.NET: warning : The file '~/.nuget/packages/fsharp.core/6.0.0/contentFiles/any/netstandard2.1/FSharp.Core.xml' does not specify a 'PublishFolderType' metadata, and a default value could not be calculated. The file will not be copied to the app bundle.
#14939
Closed
rolfbjarne opened this issue
May 9, 2022
· 2 comments
· Fixed by #17908
cd tests/monotouch-test/dotnet/macOS
make build
...
[...]/xamarin-macios/builds/downloads/dotnet-sdk-6.0.301-[...]/packs/Microsoft.macOS.Sdk/12.3.0[...]/targets/Xamarin.Shared.Sdk.targets(1439,3): warning : The file '[...]/xamarin-macios/tests/dotnet/packages/fsharp.core/6.0.0/contentFiles/any/netstandard2.1/FSharp.Core.xml' does not specify a 'PublishFolderType' metadata, and a default value could not be calculated. The file will not be copied to the app bundle. [[...]/xamarin-macios/tests/monotouch-test/dotnet/macOS/monotouch-test.csproj]
which seems to come from here: dotnet/fsharp#10579 ("Following this change, build and publish will deploy the FSharp.Core.xml doc comment file to the output directory, without the build author having to do any extra work.")
An alternative solution would be to amend our logic that figures out what to do with files in ResolvedFileToPublish (https://github.com/xamarin/xamarin-macios/blob/main/dotnet/BundleContents.md), to say something like: "If an xml file matches the filename of any assembly, then treat that xml file as PublishFolderType=Assembly" - so FSharp.Core.xml would be placed next to FSharp.Core.dll (and no warning produced). The downside is that the app would ship a file it doesn't need.
…Fixesxamarin#14939 and fixesxamarin#15897.
This fixes a warning when documentation is enabled for a project:
> The file '~/.nuget/packages/fsharp.core/6.0.0/contentFiles/any/netstandard2.1/FSharp.Core.xml' does not specify a 'PublishFolderType' metadata, and a default value could not be calculated. The file will not be copied to the app bundle.
This doesn't change any behavior (as the warning says, the file wasn't copied
to the app bundle before either), but it makes the behavior explicitly
documented and silences the warning.
Fixesxamarin#14939.
Fixesxamarin#15897.
…ixes#14939 and fixes#15897. (#17908)
This fixes a warning when documentation is enabled for a project:
> The file '~/.nuget/packages/fsharp.core/6.0.0/contentFiles/any/netstandard2.1/FSharp.Core.xml' does not specify a 'PublishFolderType' metadata, and a default value could not be calculated. The file will not be copied to the app bundle.
This doesn't change any behavior (as the warning says, the file wasn't copied
to the app bundle before either), but it makes the behavior explicitly
documented and silences the warning.
Fixes#14939.
Fixes#15897.
Repro:
Build monotouch-test for macOS:
Binlog: build-2022-05-09-145149.binlog.zip
The reason is that the FSharp.Core NuGet does this in its nuspec:
which seems to come from here: dotnet/fsharp#10579 ("Following this change, build and publish will deploy the FSharp.Core.xml doc comment file to the output directory, without the build author having to do any extra work.")
It seems this could be a workaround (untested, from dotnet/fsharp#11143 (comment))
An alternative solution would be to amend our logic that figures out what to do with files in ResolvedFileToPublish (https://github.com/xamarin/xamarin-macios/blob/main/dotnet/BundleContents.md), to say something like: "If an xml file matches the filename of any assembly, then treat that xml file as
PublishFolderType=Assembly
" - so FSharp.Core.xml would be placed next to FSharp.Core.dll (and no warning produced). The downside is that the app would ship a file it doesn't need.See also #15897 (comment).
The text was updated successfully, but these errors were encountered: